gsoc26: Link CPPM to Belle 2 project correctly ;#1850
gsoc26: Link CPPM to Belle 2 project correctly ;#1850graeme-a-stewart merged 3 commits intoHSF:mainfrom
Conversation
Fixes CPPM from having 0 projects under it ;
❌ Deploy Preview for earnest-hotteok-b1e1bf failed. Why did it fail? →
|
|
I've verified this build locally and on a separate Vercel deploy. Deployed changes:- https://hsf-github-mo0tux34f-sarguns-projects-3259a370.vercel.app/activities/gsoc.html The current Netlify environment is timing out while installing the Ruby dependencies, as it's not using the cached pre-installed version. Thanks; |
|
Thanks for the fix! This looks correct to me, but let me ping @tkuhr just for confirmation. |
|
Oh yes, sorry for forgetting CPPM in the Belle II project and thanks a lot for the fix! |
Glad I could catch it and be helpful, thank you. Happy to help! ; By the way @michmx , Could you please confirm this PR and the #1849 's deployment? The deploy preview fails for me everytime as it starts compiling the source code after installing the packages. But I've verified the changes and deployed them on Vercel if you have any concerns. https://hsf-github-mo0tux34f-sarguns-projects-3259a370.vercel.app/activities/gsoc.html ; |
|
@vvolkl @graeme-a-stewart @EdwardMoyse Sorry to bother, but this PR and #1849 is ready to go. The project mentor has approved these changes. Please let me know about any further formalities. Thanks! ; |
|
I'm not sure what happened to the CI, but the fix looks fine when previewed locally. Thanks for the fix @gluonparticle! |
Thanks, always glad to contribute! Could you please also review the #1849 ? It'd be great if we can merge this before the orgs list is announced and participants start contributing; I had deployed both PRs locally on Vercel as I mentioned; |
Simply fixes CPPM from having 0 projects under itself.
I noticed CPPM didn't have any projects under itself, and the commit ID ffb9e20 had added CPPM as an orgniazation, but missed adding it under the project.
Functional preview of the edits:- https://hsf-github-mo0tux34f-sarguns-projects-3259a370.vercel.app/activities/gsoc.html ;
Thank you ;